Add conda-based Continuous Integration and fix compilation with Gazebo on Windows installed via conda #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pattacini
approved these changes
Apr 22, 2021
traversaro
changed the title
|
WIP as I wanted to check if I can reproduce robotology/robotology-superbuild#693 and fix it before merging. |
|
Error reproduced: |
traversaro
changed the title
|
@Nicogene the PR is now ready for review. |
traversaro
changed the title
|
fyi @Tobias-Fischer, you may be happy to know that the good old red ball demo is getting a Conda-based CI. : ) |
|
How cool is that? Very nice, good work @traversaro :) |
Nicogene
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple conda-based CI. The goal is to easily test on Windows/macOS/Linux with all dependencies enabled. This complements the existing CI that instead used apt/homebrew/vcpkg (and compiles robotology dependencies from source).
Furthermore, fix compilation of the library that uses Gazebo in Windows by adding the line:
In general
target_link_directoriesandlink_directoriescommands should not be used in CMake (see the note at the end of https://cmake.org/cmake/help/latest/command/target_link_directories.html), but when linking Gazebo (andGazebo_LIBRARIES) this is unfortunately necessary due to many libraries that are provided without full paths, see http://gazebosim.org/tutorials/?tut=plugins_hello_world .This fixes issue robotology/robotology-superbuild#693 .
Similar PRs: